Add a Valgrind GitHub Actions workflow #1104
Conversation
wilfwilson
added
the
ci
wilfwilson
force-pushed
the
add-valgrind-ci-workflow
branch
from
147ead5 to
9dca240
Compare
|
I'm not seeing the valgrind job actually running, is that just me? |
Oh right it's only triggered by changes in the kernel module, any chance you can make a white space change so we can see it failing? |
wilfwilson
force-pushed
the
add-valgrind-ci-workflow
branch
3 times, most recently
from
90b826c to
ac440b0
Compare
|
@james-d-mitchell It's running! Fun times. |
wilfwilson
force-pushed
the
add-valgrind-ci-workflow
branch
from
ac440b0 to
f8b4e2c
Compare
|
Looks like it failed after running testinstall with acting methods off... with 2834 errors 😱 |
Zoiks that is not a small number |
|
Hopefully it's the same one error happening 2834 times 🤞 |
|
I'll have a look on Wednesday |
wilfwilson
force-pushed
the
add-valgrind-ci-workflow
branch
from
f8b4e2c to
9addd58
Compare
wilfwilson
force-pushed
the
add-valgrind-ci-workflow
branch
from
9addd58 to
4ff066b
Compare
|
@james-d-mitchell I suggest that you give me sufficient permissions on this repository such that I can fiddle with the respository settings vis-a-vis GitHub Actions. I propose that we merge this PR, but have the settings for the Valgrind CI job to not fail the PR status checks. i.e. it runs when necessary, and gives a pass/fail status on the relevant job, but it doesn't stop the PR from being merged, and on the lists of pull requests, it doesn't stop a PR from still having a green tick next to it (if everything is fine). Once we've addressed all of the relevant issues (ahem), we can become strict about making sure that no PR introduces new Valgrind issues. |
wilfwilson
force-pushed
the
add-valgrind-ci-workflow
branch
from
4ff066b to
0cb382e
Compare
2 participants
This is basically a copy of the file in Digraphs: thank you whoever made that!
To see that the workflow functions as expected, see here: https://github.com/wilfwilson/Semigroups/actions/runs/17740854488/job/50414239468
Note that the job fails, because Valgrind does indeed find some issues...